search

revelrylabs / sassy-npm-importer

Import SASS from npm via a customizable prefix.
MIT License
18 stars 2 forks source link

Added update to correctly link to packages included using npm link #2

Closed mklemme closed 7 years ago

mklemme commented 7 years ago

I'm working on a pattern library that has been included in my project using npm link. The importer was throwing an error since the actual location of the package was in a different repo (dir). Updated the logic in the locator so that it doesn't assume the package is in the local node_module directory

Thanks for this project. Just started my first react app on create-react-app and this lets me avoid doing npm eject for a while. Cheers.

jwietelmann commented 7 years ago

@mklemme Thanks! Will merge and version-bump when I get a moment.

jwietelmann commented 7 years ago

@mklemme Can you give me a specific set of steps I could take to manually test your npm link scenario? I ran my existing tests against your change, and they pass, so I'm going to merge in a minute here, but I would like to know more so I can write an automated test against this case.