revelrylabs / text_chunker_ex

A library for semantically coherent text chunking
MIT License
66 stars 4 forks source link

14 // Adds metadata option to add chunks to metadata #15

Closed stuartjohnpage closed 5 months ago

stuartjohnpage commented 5 months ago

connects to #14

Overview

The thing I don't like about this is the empty metadata property that we now get on chunks. I was toying with either a) doing some fancy macro that can switch up the struct definition, or defaulting it to nil. Or this might actually be a good thing/necessary evil to get the struct definition nice and stable

Either way, please let me know what you think. Is this what you had in mind @gordoneliel?

stuartjohnpage commented 5 months ago

I'm closing this for now, pending discussion in #14