reverbdotcom / reverb-magento

Magento 1.x plugin for syncing with Reverb
Other
7 stars 10 forks source link

Image Sync Revamp #109

Closed dunagan5887 closed 9 years ago

dunagan5887 commented 9 years ago
skwp commented 9 years ago

as per discussion in chat let's make sure we key off of the unique magento gallery id and use the filename as a column that's not necessarily searchable

dunagan5887 commented 9 years ago

"use the filename as a column that's not necessarily searchable"

By this do you mean you won't want to be able to search by filename? By putting the subject_id column onto the database table, we get sorting and filtering on that column for free in the grids

Virtually any column we add to the database table comes with free sorting and filtering. The current issue with not being able to sort/filter is that a number of the columns in that grid come from the serialized arguments object field, which doesn't allow for an immediate implementation of sorting and filtering

skwp commented 9 years ago

search by file name is good to have

Yan Pritzker yanpritzker.com via iPhone

On Sep 24, 2015, at 11:31 PM, Sean Dunagan notifications@github.com wrote:

"use the filename as a column that's not necessarily searchable"

By this do you mean you won't want to be able to search by filename? By putting into the database table, we get sorting and filtering on that column for free in the grids

— Reply to this email directly or view it on GitHub.