search

reverbdotcom / reverb-magento

Magento 1.x plugin for syncing with Reverb
Other
7 stars 10 forks source link

Renamed rev_sync attribute to sync_to_reverb for clarity [Fix #115] #116

Closed StevenWolfe closed 9 years ago

StevenWolfe commented 9 years ago

Renamed rev_sync attribute to sync_to_reverb and updated usages

skwp commented 9 years ago

Thanks for the PR! is this safe to apply to existing installations?

StevenWolfe commented 9 years ago

No, this won't handle migration. The installer will need a new script. I'll be making a few more pull requests with some changes which MSL will need to go live. This one is trivial, but some are critical.

skwp commented 9 years ago

Could you please provide a migration script? This is a little beyond me and I'd like to merge the PR but not if it impacts existing customers negatively.

StevenWolfe commented 9 years ago

let's leave this out for now then; the migration isn't relevant to MSL and I'd rather not spend their time on it--it can be migrated in the future.

skwp commented 9 years ago

Sounds good thanks. I'll keep this open for a bit to see if our developer can knock this out pretty quickly

skwp commented 9 years ago

@dunagan5887 i'm not merging this one because it would require a data migration

dunagan5887 commented 9 years ago

Agreed, its more cosmetic than it is functional

StevenWolfe commented 9 years ago

Closing - Pull #125 includes a migration script and renamed two other rev_* attributes