Rename reverb attributes to use "reverb_" prefix instead of "rev_" [Fix #115]

reverbdotcom / reverb-magento

Magento 1.x plugin for syncing with Reverb

Other

7 stars 10 forks source link

Rename reverb attributes to use "reverb_" prefix instead of "rev_" [Fix #115] #125

Closed StevenWolfe closed 8 years ago

StevenWolfe commented 9 years ago

Tested migration script against 0.4.4

StevenWolfe commented 9 years ago

closing temporarily - looks like the squash may have an error

StevenWolfe commented 9 years ago

False alarm. Not enough coffee.

StevenWolfe commented 9 years ago

The <version> value in config.xml will need to be updated, and the file renamed. It would also be good to do a code-wide search for any usages of the old attribute names after the merge:

RevProductId -> ReverbProductId
rev_product_id -> reverb_product_id
RevProductUrl -> ReverbProductUrl
rev_product_url -> reverb_product_url
RevSync -> ReverbSyncEnabled
rev_sync -> reverb_sync_enabled

skwp commented 9 years ago

Thanks Steve. I think this PR is a nice to have rename that doesn't really impact anything but does put a lot of burden on us not to break any existing customers. I'm inclined not to merge it given that I can't guarantee its safety..

StevenWolfe commented 9 years ago

no problem, we're using it but I can convert back to the old attribute names--or I can double-check the safety and redo the pull request in a while

skwp commented 9 years ago

if you redo the PR that would be a big help. again I appreciate your work, I just don't want to be put in the position of breaking other customers by accident

dunagan5887 commented 9 years ago

I would agree that this is a risky merge due to the existing client instances

skwp commented 8 years ago

sorry, decided to close this for the time being due to the risk/reward quotient :)