search

reverbdotcom / reverb-magento

Magento 1.x plugin for syncing with Reverb
Other
7 stars 10 forks source link

Fixing order creation/update crons to execute API orders retrieval be… #167

Closed dunagan5887 closed 8 years ago

dunagan5887 commented 8 years ago

Fix #160

skwp commented 8 years ago

So order retrieval was indeed broken? Can you please comment a bit more on this fix? thanks

dunagan5887 commented 8 years ago

There's nothing wrong with the logic for the order retrieval, which is why manually syncing via the admin panel button worked fine. The issue was that the functionality called from the crontab only processed orders which had already been retrieved, it didn't actually trigger the retrieval from the Reverb API. I'm not sure how/when this happened, but it may have been back when the decision was made to separate and stagger the creation/update cron jobs. Again, the actual functionality in terms of retrieving/creating/update orders was not broken.

dunagan5887 commented 8 years ago

In other words the order retrieval was never broken, it just wasn't being invoked by the crontab

skwp commented 8 years ago

got it. and do you think cron on our test instance is working or is that a separate issue?

dunagan5887 commented 8 years ago

It is now working with the new entry I created, I monitored the database after my new entry last night and new rows were being populated/executed in the cron_schedule table

skwp commented 8 years ago

cron looks good, could you please take a look at #166 - the implementation is reversed