search

reverbdotcom / reverb-magento

Magento 1.x plugin for syncing with Reverb
Other
7 stars 10 forks source link

Issues/GitHub 164 #168

Closed dunagan5887 closed 8 years ago

dunagan5887 commented 8 years ago

Fix #164

The most recent issue (the Pro-Audio being sent in the wrong field) was in regards to the initial Reverb category population from the json. I have fixed that issue.

Clients who have already mapped categories will need to re-map the categories unfortunately. If this is a major issue, I can update the upgrade script to repopulate the mapping for them, this would probably take an hour or two. Let me know if you want me to go ahead with that

skwp commented 8 years ago

Yes please update the script as some customers have many categories and it's not clear what remapping means as when I loaded my mapping screen it already looked mapped. I think it will be a source of confusion Thanks

Sent from my iPhone

On Nov 19, 2015, at 5:48 PM, Sean Dunagan notifications@github.com wrote:

Fix #164

The most recent issue (the Pro-Audio being sent in the wrong field) was in regards to the initial Reverb category population from the json. I have fixed that issue.

Clients who have already mapped categories will need to re-map the categories unfortunately. If this is a major issue, I can update the upgrade script to repopulate the mapping for them, this would probably take an hour or two. Let me know if you want me to go ahead with that

You can view, comment on, or merge this pull request online at:

https://github.com/reverbdotcom/reverb-magento/pull/168

Commit Summary

Repopulating the Reverb category table Merge branch 'master' into issues/github_164 Reverting the patch to remove the category sync File Changes

M app/code/community/Reverb/ReverbSync/Helper/Sync/Category.php (64) M app/code/community/Reverb/ReverbSync/Model/Mapper/Product.php (7) M app/code/community/Reverb/ReverbSync/Model/Mysql4/Category/Reverb.php (2) M app/code/community/Reverb/ReverbSync/etc/config.xml (2) A app/code/community/Reverb/ReverbSync/sql/reverbsync_setup/mysql4-upgrade-0.1.10-0.1.11.php (8) Patch Links:

https://github.com/reverbdotcom/reverb-magento/pull/168.patch https://github.com/reverbdotcom/reverb-magento/pull/168.diff — Reply to this email directly or view it on GitHub.

dunagan5887 commented 8 years ago

Due to the Foreign Key relationship on the mapping table, there should be no data on the mapping screen after the upgrade script loads.

dunagan5887 commented 8 years ago

Let me see if I can do something else that would be quicker

dunagan5887 commented 8 years ago

The quick way does not appear to be a good solution, I'll have to modify the upgrade script to re-map the categories after reloading the reverb_categories table. Unfortunately I won't be able to get to this until later next week due to my deluge of doctor's appointments coming as well as Thanksgiving

skwp commented 8 years ago

Ok so if I merge this it will clear out mappings? That might be fine for now. I will check with a few customers. Thanks

Sent from my iPhone

On Nov 19, 2015, at 8:39 PM, Sean Dunagan notifications@github.com wrote:

The quick way does not appear to be a good solution, I'll have to modify the upgrade script to re-map the categories after reloading the reverb_categories table. Unfortunately I won't be able to get to this until later next week due to my deluge of doctor's appointments coming as well as Thanksgiving

— Reply to this email directly or view it on GitHub.

dunagan5887 commented 8 years ago

Right, there will be no mappings from Magento to Reverb categories

skwp commented 8 years ago

Ok that's fine, we dont' need a migration script

skwp commented 8 years ago

Sorry to say Sean this code is still not right. Now the top level category is being put into "categories". Example:

"categories":["microphones","pro-audios"],"product_type":"pro-audios"

Should be: "categories":["microphones"],"product_type":"pro-audios"

skwp commented 8 years ago

Reverted 1bb9bf6 again