Fix 182: changed reverb attribute codes, labels and a little housekee…

reverbdotcom / reverb-magento

Magento 1.x plugin for syncing with Reverb

Other

7 stars 10 forks source link

Fix 182: changed reverb attribute codes, labels and a little housekee… #185

Closed zztimur closed 8 years ago

zztimur commented 8 years ago

Fix for issue #182.

Attribute id prefixes changed from rev to reverb
Attribute labels are updated from Rev* to Reverb*
Some basic clean up of setup scripts
Code adjustments due to rev->reverb modifications

skwp commented 8 years ago

Awesome thanks for the contribution!

skwp commented 8 years ago

Thanks for the contrib, it seems we have some merge conflicts now though. Also how did you test this? It seems to me there are two possible bugs there with the variable not renamed inside getTargetProductId and getTargetProductUrl? Thanks

zztimur commented 8 years ago

Hey @skwp, I fixed the stuff you pointed out. Thanks.

I tested after I deleted the module, completely dropped reverb tables, removed all resource references.

What's the conflict?

skwp commented 8 years ago

not sure github is showing a merge conflict. let me check it out

skwp commented 8 years ago

Merged my own branch of thsi thanks