zztimur
commented
8 years ago Added code to address the issue #217.
It was really hard to work with all the duplicate code and bugs, where action buttons wouldn't work. So I took some time to slightly adjust the code for admin controllers.
Quick overview:
- There was bunch of redundant logging functions involved, I removed the duplicates and combined logging for controller action errors in one function.
- IndexAction's for controllers extended from ProcessQueue were repetitive. They were pulled up to Reverb/ProcessQueue/controllers/Adminhtml/ProcessQueue/IndexController.php in the _initAction as preparation.
- Same goes for actOnTaskAction. With all those properties per each controller, there's really no need to have that function per each child class.
- return URL parameter on action buttons was implemented so inconsistently and randomly, that I removed it, as there is no case were it's needed.
- pulled some constants to ProcessQueue level. Removed unused ones.
skwp
dunagan5887
Resolution for issue #215