search

reverbdotcom / reverb-magento

Magento 1.x plugin for syncing with Reverb
Other
7 stars 10 forks source link

Reverb Orders without an address should still be created #237

Closed dunagan5887 closed 8 years ago

dunagan5887 commented 8 years ago

The orders should be created with the value "No Address" populating all fields

dunagan5887 commented 8 years ago

@kylecrum Entering the value of "No Address" for the country field will result in "Norway" being shown in the admin panel Order Edit screen. Is that acceptable or should I change the country_code to be US?

kylecrum commented 8 years ago

@dunagan5887 can that be blank so that it shows the default? (I'm guessing it shows norway because that's the closest to "No Address".)

dunagan5887 commented 8 years ago

If no value is entered, the address will fail validation. For some reason, the value of "Local Pickup" does not show any country in the admin panel. Should I just choose some value that doesn't have an associated country?

kylecrum commented 8 years ago

@dunagan5887 Ideally, ya.

dunagan5887 commented 8 years ago

The empty country code patch is now on this branch

kylecrum commented 8 years ago

@dunagan5887 is the code ready to go? Can you make a PR if it is?