Closed zztimur closed 8 years ago
So since we are doing calls via urls, it makes sense to url encode the sku for reverb. I'll post a pull request shortly.
Is this fixed by this PR? https://github.com/reverbdotcom/reverb-magento/pull/239 @zztimur ?
Yes
On Apr 27, 2016, at 3:16 PM, Kyle Crum notifications@github.com wrote:
Is this fixed by this PR? #239 @zztimur ?
— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub
Please see discussion here: https://github.com/reverbdotcom/reverb-magento/pull/242 I don't think your fix did what you think it shoudl do. You only need to urlencode the GET request
@skwp Any news from your team? Was this tested on API?
We will be fixing the tab problem on our side probably by next week or sooner
@zztimur should be fixed on our end.
awesome thanks
On Apr 28, 2016, at 3:05 PM, Kyle Crum notifications@github.com wrote:
@zztimur https://github.com/zztimur should be fixed on our end.
— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/reverbdotcom/reverb-magento/issues/238#issuecomment-215545989
If you have a product with an SKU with a special character it won't sync correctly.
Here's an example. We had a product with a TAB symbol somehow ending up being part of SKU. Say SKU in magento is "product-abcd".
Here's what happens to it.