#240 Updating listing sync to set task to ABORTED if a product is set…

[dunagan5887]

Fix #240 Updating listing sync to set task to ABORTED if a product is set to not be synced to Reverb (or if the product is not a simple or configurable product)

[dunagan5887]

I'm going to sanity check this on 1.7 and 1.12 but this should be ready to roll

[zztimur]

Would this listing display with error status in admin?

On Wed, Apr 27, 2016 at 3:43 PM, Sean Dunagan notifications@github.com wrote:

I'm going to sanity check this on 1.7 and 1.12 but this should be ready to roll

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/reverbdotcom/reverb-magento/pull/243#issuecomment-215222103

-- Sent from my iPhone

[dunagan5887]

Due to the legacy structure in place to display listing sync results, this would not be shown in the admin panel. I would need to hack together some code to make that happen

[kylecrum]

I don't see this as an error, anyway. No error would be expected behavior, IMO, since it's techincally doing what the seller is telling us to do. Seeing "error" for something that the seller set to not be synced doesn't seem like good UX.

[dunagan5887]

So should I set this to place the queue-task in a COMPLETE state as opposed to ABORTED?

[kylecrum]

@dunagan5887 are those our only options? To me it's more like "ignored" than anything else.

[dunagan5887]

I can create an IGNORED state I suppose, that wouldn't be a trivial fix/update. Currently it's either COMPLETE or ABORTED

[kylecrum]

ABORTED it is then.

[dunagan5887]

Just checked this on 1.7 and 1.12 and it looks good to go