search

reverbdotcom / reverb-magento

Magento 1.x plugin for syncing with Reverb
Other
7 stars 10 forks source link

Why does the order have processing status when it's "pending_review" #247

Closed zztimur closed 7 years ago

zztimur commented 8 years ago

Magento order status changes to processing, but the order is "pending_review" in reverb order status. At which point is it safe to ship?

kylecrum commented 8 years ago

@zztimur it's safe to ship when it is paid . pending review means that our fraud team is looking at it.

zztimur commented 8 years ago

Wouldn't it be safer to have a status on magento side that would be "pending reverb" so we don't ship until you clear the transaction and move it to the next step - "processing"?

On Apr 28, 2016, at 8:26 PM, Kyle Crum notifications@github.com wrote:

@zztimur it's safe to ship when it is paid . pending review means that our fraud team is looking at it.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub

kylecrum commented 8 years ago

@zztimur to me, "processing" means that the payment is still in process. I hope that people don't ship goods before the payment has cleared.

zztimur commented 8 years ago

Magento order statuses are: Pending: Pending orders are brand new orders that have not been processed. Typically, these orders need to be invoiced and shipped. Pending PayPal: Pending PayPal orders are brand new orders that have not been cleared by PayPal. [...] Processing: Processing means that orders have either been invoiced or shipped, but not both. Complete: Orders marked as complete have been invoiced and have shipped. Cancelled: Cancelled orders should be used if orders are cancelled or if the orders have not been paid for. Closed: Closed orders are orders that have had a credit memo assigned to it and the customer has been refunded for their order. On Hold: Orders placed on hold must be taken off hold before continuing any further actions. We need to get a different status for reverb-review and reverb-passed-review.

Makes sense?

On Apr 29, 2016, at 8:59 AM, Kyle Crum notifications@github.com wrote:

@zztimur to me, "processing" means that the payment is still in process. I hope that people don't ship goods before the payment has cleared.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub

kylecrum commented 8 years ago

@zztimur I don't like any of those, statuses, unfortunately :(

I mean, we can make it Pending PayPal, that's the most accurate, although, it is not a Paypal payment, but the same process is happening there.

Isn't there an on hold status?

zztimur commented 8 years ago

You can introduce new ones. Sean would know. So instead of it’d be “Reverb Review” and then “Reverb Passed” or something along those lines.

On Apr 29, 2016, at 11:09 AM, Kyle Crum notifications@github.com wrote:

@zztimur https://github.com/zztimur I don't like any of those, statuses, unfortunately :(

I mean, we can make it Pending PayPal, that's the most accurate, although, it is not a Paypal payment, but the same process is happening there.

Isn't there an on hold status?

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/reverbdotcom/reverb-magento/issues/247#issuecomment-215783327

dunagan5887 commented 8 years ago

There is an On Hold Magento Order status. Basically in this status no actions will be allowed to be taken on the order until it is taken out of Hold state.

In terms of creating new statuses for Magento Order objects, I would strongly advise against doing so. A lot of Magento functionality is based off of conditions regarding an order's status, and creating new statuses could lead to unintended consequences

zztimur commented 8 years ago

@dunagan5887, can reverb-review set order status as "on-hold", and then once it passes review "processing"?

Right now the status is set to processing while on review.

dunagan5887 commented 8 years ago

I'm going to need some catching up here. Are "Reverb Review" and "Reverb Passed" statuses that are communicated from Reverb to Magento?

kylecrum commented 8 years ago

no, those would be custom statuses, I think. I'd like to just use the built-in On Hold status if we can.

dunagan5887 commented 8 years ago

I guess I need clarification on the following:

can reverb-review set order status as "on-hold"

Do you mean put to Magento-status-On-Hold manually by an admin?

then once it passes review "processing"?

Currently once Reverb communicates the Reverb-Order-Status-"Paid" to Magento, the Magento Order is set to Magento-status-Processing by creating an invoice

Right now the status is set to processing while on review

I'm confused as to how this is happening. Are you saying that the Reverb-Order-Status-"Paid" communication is being made to Magento even though Reverb orders haven't been paid?

It may be easier to have a call regarding all of this

kylecrum commented 8 years ago

@dunagan5887 we have a status called "pending_review" and I think the question is what to translate that to in Magento terms.

dunagan5887 commented 8 years ago

That sounds like "Hold" to me

zztimur commented 8 years ago

Yes, but currently it sets as "processing"

On Apr 29, 2016, at 12:39 PM, Sean Dunagan notifications@github.com wrote:

That sounds like "Hold" to me

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub

dunagan5887 commented 8 years ago

Yes, but currently it sets as "processing"

What is "it" that is setting it to Processing?

kylecrum commented 8 years ago

@zztimur please link to code that you feel may be incorrect.

zztimur commented 8 years ago

https://github.com/reverbdotcom/reverb-magento/blob/2b9f4b53e894c88c7d638f5a7bf1fa61a51192dc/app/code/community/Reverb/ReverbSync/Model/Sync/Order/Update.php#L40

dunagan5887 commented 8 years ago

Currently the only Reverb-Order-Status values which trigger any Magento functionality are "cancelled" and "paid". If Reverb sends Reverb-Order-Status-"Pending Review" the module will not place the order in Processing state. There are currently no event observer listening for pending-review

zztimur commented 8 years ago

@kylecrum What's the sequence of statuses on reverb side?

kylecrum commented 8 years ago

@zztimur depends on the order. However, when it reaches "paid", then it's safe to ship. Order table here: https://dev.reverb.com/docs/syncing-orders

kylecrum commented 8 years ago

In general, "paid" is your magic state of saying "it's ok to ship".

zztimur commented 8 years ago

We’ve had an order with reverb_status: pending_review and magent: processing. Is it possible that something was paid and then went under review?

On Apr 29, 2016, at 1:34 PM, Kyle Crum notifications@github.com wrote:

In general, "paid" is your magic state of saying "it's ok to ship".

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/reverbdotcom/reverb-magento/issues/247#issuecomment-215841277

kylecrum commented 8 years ago

@zztimur you'd have to give me details, but once it is paid, we will not put it under review again.

dunagan5887 commented 8 years ago

We’ve had an order with reverb_status: pending_review and magent: processing.

That would be possible if a Magento admin manually tried to trigger an invoice, or if Reverb sent a "pending_review" after sending a "paid" status