search

reverbdotcom / reverb-magento

Magento 1.x plugin for syncing with Reverb
Other
7 stars 10 forks source link

Q: Adding prefix to reverb orders #250

Closed zztimur closed 7 years ago

zztimur commented 8 years ago

What do you think of adding prefix to reverb orders in magento?

kylecrum commented 8 years ago

Maybe? What are you thinking? Not sure of the use case here.

zztimur commented 8 years ago

Example: M2E extension most popular for handling eBay and amazon sync, uses prefixes in front of orders number. Use case: easily distinguish sales channel - things can be handled differently for magento sales vs external sale.

So instead of "1000049494" order would be "R-1000049494" or something like that (for reverb).

On Tue, May 3, 2016 at 5:24 PM, Kyle Crum notifications@github.com wrote:

Maybe? What are you thinking? Not sure of the use case here.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/reverbdotcom/reverb-magento/issues/250#issuecomment-216682904

-- Sent from my iPhone

kylecrum commented 8 years ago

I'll ask other shops but I don't get the sense that this is an issue with any of our current integrators.

zztimur commented 8 years ago

It's not an issue, but a feature. So if I implement it, would you merge it via PR?

Also wanted to hear @dunagan5887 take on this.

kylecrum commented 8 years ago

That would change how all of the orders work for people who upgrade, so I'm hesitant to do so if people don't seem to want it.

skwp commented 8 years ago

If you do implement I would do so as a configuration option so it won't affect existing orders. By default there should be no prefix

Sent from my iPhone

On May 3, 2016, at 10:14 PM, Kyle Crum notifications@github.com wrote:

That would change how all of the orders work for people who upgrade, so I'm hesitant to do so if people don't seem to want it.

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub

cpaterso commented 8 years ago

Just confirming that this would be an appreciated feature! We, like many others, use M2E Pro for eBay and Amazon, and it's nice to have a custom prefix for the channel so that we can sort by channel easily in the admin panel. Obviously it could be turned on or off just like M2E, so it doesn't hurt anyone who doesn't want to use it.

kylecrum commented 8 years ago

Great! We'd happily accept pull requests.