reverbrain / eblob

Eblob is an append-only low-level IO library, which saves data in blob files. Created as low-level backend for elliptics
GNU Lesser General Public License v3.0
104 stars 29 forks source link

fixed cpp binding #10

Closed tinybit closed 11 years ago

tinybit commented 11 years ago

guys, you can't just assume that any system has or will always allow some user code to get access to /dev/stdout

bioothod commented 11 years ago

What's the problem, use different constructor: eblob::eblob(const char log_file, const int log_level, struct eblob_config cfg)

tinybit commented 11 years ago

the problem is that if you use different one eblob::eblob(struct eblob_config *cfg) and pass cgf struct that contains initialised logger, you get this nasty behaviour, you guys open /dev/stdout first, then check for cfg->log existence, that's outright wrong. and i got in this mess in my code.