search

reverbrain / eblob

Eblob is an append-only low-level IO library, which saves data in blob files. Created as low-level backend for elliptics
GNU Lesser General Public License v3.0
104 stars 29 forks source link

Exception instead of error code #101

Closed shaitan closed 9 years ago

shaitan commented 9 years ago

I've returned using exception instead of error code in eblob c++ binding and made messages of these exceptions in common style. Also I've fixed cpp tests.

bioothod commented 9 years ago

This still breaks API for older methods which returned 'int', is this ok with your guys?

shaitan commented 9 years ago

Yes it is ok, because all these methods returned 0 if them have been succeeded and threw exception in other cases. So these methods have never returned nonzero value and it should be ignored.

bioothod commented 9 years ago

Should I make new eblob (and elliptics) versions, or there will be new commits?

shaitan commented 9 years ago

Yes, I'm preparing 2-3 pull requests to eblob and elliptics.