python: fixed undefined behaviour in python iterator callback

reverbrain / eblob

Eblob is an append-only low-level IO library, which saves data in blob files. Created as low-level backend for elliptics

GNU Lesser General Public License v3.0

104 stars 29 forks source link

python: fixed undefined behaviour in python iterator callback #148

Closed bioothod closed 8 years ago

bioothod commented 8 years ago

Spotted by @euroelessar

shaitan commented 8 years ago

:+1:

shaitan commented 8 years ago

Why did you merge this PR if all checks were failed?

bioothod commented 8 years ago

These checks break all the time, I virtually do not know what they mean. It is useless for everyone but people who have access to your internal servers.

It compiles just fine here (gcc 5.1), the proper fix would be elimination of namespace escaping ::, also casting to size_t is not valid, it should be uint64_t and proper error checking. I will cook up patch tomorrow

abudnik commented 8 years ago

https://ru.wikipedia.org/wiki/%D0%94%D0%B8%D0%B3%D1%80%D0%B0%D1%84_%28%D1%8F%D0%B7%D1%8B%D0%BA%D0%B8_%D0%A1%D0%B8%29#.D0.A2.D0.B0.D0.B1.D0.BB.D0.B8.D1.86.D0.B0_.D0.B4.D0.B8.D0.B3.D1.80.D0.B0.D1.84.D0.BE.D0.B2_C