Removed index_offset in eblob_base_ctl, replaced its use by index_size. Replaced pread() by __eblob_read_ll() in blob iteration

reverbrain / eblob

Eblob is an append-only low-level IO library, which saves data in blob files. Created as low-level backend for elliptics

GNU Lesser General Public License v3.0

104 stars 29 forks source link

Removed index_offset in eblob_base_ctl, replaced its use by index_size. Replaced pread() by __eblob_read_ll() in blob iteration #85

Closed shaitan closed 10 years ago

shaitan commented 10 years ago

In most cases index_offset was equal to index_size and defined where new record should be written. Only case when index_offset wasn't equal to index_size was index_offset of closed blob. It was equal to 0. This situation had made confusion, so it was decided to remove index_offset. Also there was satisfied TODO comment and used __eblob_read_ll() instead of pread().

bioothod commented 10 years ago

Please add above description (and even more if needed) to commit messages and comments in the code next time. Thank you.

SaveTheRbtz commented 10 years ago

LGTM. Thanks for refactoring that stuff!