Allow multiple nonlinear systems

hugary1995 commented 7 months ago

Add CopyVariable model
Allow multiple decoupled nonlinear systems
Setup an example CP single crystal problem using decoupled time integration

hugary1995 commented 7 months ago

I'll rebase this on main once #110 is merged.

hugary1995 commented 7 months ago

If you want to review this one first, just look at the last commit.

github-actions[bot] commented 7 months ago

Test Results (macos-latest-Debug-ON)

3 files ±0 3 suites ±0 1m 19s :stopwatch: - 1m 3s 470 tests +2 470 :white_check_mark: +2 0 :zzz: ±0 0 :x: ±0 3 049 runs +2 3 049 :white_check_mark: +2 0 :zzz: ±0 0 :x: ±0

Results for commit 63583511. ± Comparison against base commit f6c8ea99.

This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.

``` regression_tests.global ‑ solid mechanics/crystal_plasticity/basic_single_crystal/model.i ``` ``` regression_tests.global ‑ solid mechanics/crystal_plasticity/single_crystal_coupled/model.i regression_tests.global ‑ solid mechanics/crystal_plasticity/single_crystal_decoupled/model.i regression_tests.global ‑ solid mechanics/crystal_plasticity/single_crystal_decoupled_explicit_orientation/model.i ```

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 7 months ago

Test Results (ubuntu-latest-Release-ON)

3 files ±0 3 suites ±0 35s :stopwatch: +5s 475 tests +2 475 :white_check_mark: +2 0 :zzz: ±0 0 :x: ±0 3 052 runs +2 3 052 :white_check_mark: +2 0 :zzz: ±0 0 :x: ±0

Results for commit 24d0858e. ± Comparison against base commit 2e03afd2.

This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.

``` regression_tests.global ‑ solid mechanics/crystal_plasticity/basic_single_crystal/model.i ``` ``` regression_tests.global ‑ solid mechanics/crystal_plasticity/single_crystal_coupled/model.i regression_tests.global ‑ solid mechanics/crystal_plasticity/single_crystal_decoupled/model.i regression_tests.global ‑ solid mechanics/crystal_plasticity/single_crystal_decoupled_explicit_orientation/model.i ```

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 7 months ago

Test Results (macos-latest-Release-ON)

3 files ±0 3 suites ±0 1m 26s :stopwatch: +53s 470 tests +2 470 :white_check_mark: +2 0 :zzz: ±0 0 :x: ±0 3 047 runs +2 3 047 :white_check_mark: +2 0 :zzz: ±0 0 :x: ±0

Results for commit 63583511. ± Comparison against base commit f6c8ea99.

This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.

``` regression_tests.global ‑ solid mechanics/crystal_plasticity/basic_single_crystal/model.i ``` ``` regression_tests.global ‑ solid mechanics/crystal_plasticity/single_crystal_coupled/model.i regression_tests.global ‑ solid mechanics/crystal_plasticity/single_crystal_decoupled/model.i regression_tests.global ‑ solid mechanics/crystal_plasticity/single_crystal_decoupled_explicit_orientation/model.i ```

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 7 months ago

Test Results (ubuntu-latest-Debug-ON)

3 files ±0 3 suites ±0 1m 39s :stopwatch: +16s 475 tests +2 475 :white_check_mark: +2 0 :zzz: ±0 0 :x: ±0 3 054 runs +2 3 054 :white_check_mark: +2 0 :zzz: ±0 0 :x: ±0

Results for commit 24d0858e. ± Comparison against base commit 2e03afd2.

This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.

``` regression_tests.global ‑ solid mechanics/crystal_plasticity/basic_single_crystal/model.i ``` ``` regression_tests.global ‑ solid mechanics/crystal_plasticity/single_crystal_coupled/model.i regression_tests.global ‑ solid mechanics/crystal_plasticity/single_crystal_decoupled/model.i regression_tests.global ‑ solid mechanics/crystal_plasticity/single_crystal_decoupled_explicit_orientation/model.i ```

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 7 months ago

Test Results (macos-latest-Debug-OFF)

3 files ±0 3 suites ±0 1m 46s :stopwatch: -10s 470 tests +2 470 :white_check_mark: +2 0 :zzz: ±0 0 :x: ±0 3 049 runs +2 3 049 :white_check_mark: +2 0 :zzz: ±0 0 :x: ±0

Results for commit 63583511. ± Comparison against base commit f6c8ea99.

This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.

``` regression_tests.global ‑ solid mechanics/crystal_plasticity/basic_single_crystal/model.i ``` ``` regression_tests.global ‑ solid mechanics/crystal_plasticity/single_crystal_coupled/model.i regression_tests.global ‑ solid mechanics/crystal_plasticity/single_crystal_decoupled/model.i regression_tests.global ‑ solid mechanics/crystal_plasticity/single_crystal_decoupled_explicit_orientation/model.i ```

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 7 months ago

Test Results (macos-latest-Release-OFF)

3 files ±0 3 suites ±0 43s :stopwatch: -1s 470 tests +2 470 :white_check_mark: +2 0 :zzz: ±0 0 :x: ±0 3 047 runs +2 3 047 :white_check_mark: +2 0 :zzz: ±0 0 :x: ±0

Results for commit 63583511. ± Comparison against base commit f6c8ea99.

This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.

``` regression_tests.global ‑ solid mechanics/crystal_plasticity/basic_single_crystal/model.i ``` ``` regression_tests.global ‑ solid mechanics/crystal_plasticity/single_crystal_coupled/model.i regression_tests.global ‑ solid mechanics/crystal_plasticity/single_crystal_decoupled/model.i regression_tests.global ‑ solid mechanics/crystal_plasticity/single_crystal_decoupled_explicit_orientation/model.i ```

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 7 months ago

Test Results (ubuntu-latest-Release-OFF)

3 files ±0 3 suites ±0 35s :stopwatch: +6s 475 tests +2 475 :white_check_mark: +2 0 :zzz: ±0 0 :x: ±0 3 052 runs +2 3 052 :white_check_mark: +2 0 :zzz: ±0 0 :x: ±0

Results for commit 24d0858e. ± Comparison against base commit 2e03afd2.

This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.

``` regression_tests.global ‑ solid mechanics/crystal_plasticity/basic_single_crystal/model.i ``` ``` regression_tests.global ‑ solid mechanics/crystal_plasticity/single_crystal_coupled/model.i regression_tests.global ‑ solid mechanics/crystal_plasticity/single_crystal_decoupled/model.i regression_tests.global ‑ solid mechanics/crystal_plasticity/single_crystal_decoupled_explicit_orientation/model.i ```

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 7 months ago

Test Results (ubuntu-latest-Debug-OFF)

3 files ±0 3 suites ±0 1m 36s :stopwatch: +13s 475 tests +2 475 :white_check_mark: +2 0 :zzz: ±0 0 :x: ±0 3 054 runs +2 3 054 :white_check_mark: +2 0 :zzz: ±0 0 :x: ±0

Results for commit 24d0858e. ± Comparison against base commit 2e03afd2.

This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.

``` regression_tests.global ‑ solid mechanics/crystal_plasticity/basic_single_crystal/model.i ``` ``` regression_tests.global ‑ solid mechanics/crystal_plasticity/single_crystal_coupled/model.i regression_tests.global ‑ solid mechanics/crystal_plasticity/single_crystal_decoupled/model.i regression_tests.global ‑ solid mechanics/crystal_plasticity/single_crystal_decoupled_explicit_orientation/model.i ```

:recycle: This comment has been updated with latest results.

reverendbedford commented 7 months ago

Placeholder note for later review: need to check that state variables remain on the output axis.

github-actions[bot] commented 6 months ago

Python Binding Test Results (ubuntu-latest)

63 tests ±0 39 :white_check_mark: ±0 2s :stopwatch: ±0s 1 suites ±0 24 :zzz: ±0 1 files ±0 0 :x: ±0

Results for commit 24d0858e. ± Comparison against base commit 2e03afd2.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 6 months ago

Python Binding Test Results (macos-latest)

63 tests ±0 39 :white_check_mark: ±0 20s :stopwatch: +18s 1 suites ±0 24 :zzz: ±0 1 files ±0 0 :x: ±0

Results for commit 63583511. ± Comparison against base commit f6c8ea99.

hugary1995 commented 6 months ago

Placeholder note for later review: need to check that state variables remain on the output axis.

I added an entry point for each model to check and write custom "diagnostics" information.

github-actions[bot] commented 6 months ago

Python Binding Test Results (macos-12)

63 tests ±0 39 :white_check_mark: ±0 2s :stopwatch: -17s 1 suites ±0 24 :zzz: ±0 1 files ±0 0 :x: ±0

Results for commit 24d0858e. ± Comparison against base commit 2e03afd2.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 6 months ago

Test Results (macos-12-Debug-ON)

3 files ±0 3 suites ±0 1m 27s :stopwatch: -51s 475 tests +2 475 :white_check_mark: +2 0 :zzz: ±0 0 :x: ±0 3 054 runs +2 3 054 :white_check_mark: +2 0 :zzz: ±0 0 :x: ±0

Results for commit 24d0858e. ± Comparison against base commit 2e03afd2.

This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.

``` regression_tests.global ‑ solid mechanics/crystal_plasticity/basic_single_crystal/model.i ``` ``` regression_tests.global ‑ solid mechanics/crystal_plasticity/single_crystal_coupled/model.i regression_tests.global ‑ solid mechanics/crystal_plasticity/single_crystal_decoupled/model.i regression_tests.global ‑ solid mechanics/crystal_plasticity/single_crystal_decoupled_explicit_orientation/model.i ```

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 6 months ago

Test Results (macos-12-Release-ON)

3 files ±0 3 suites ±0 1m 27s :stopwatch: +15s 475 tests +2 475 :white_check_mark: +2 0 :zzz: ±0 0 :x: ±0 3 052 runs +2 3 052 :white_check_mark: +2 0 :zzz: ±0 0 :x: ±0

Results for commit 24d0858e. ± Comparison against base commit 2e03afd2.

This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.

``` regression_tests.global ‑ solid mechanics/crystal_plasticity/basic_single_crystal/model.i ``` ``` regression_tests.global ‑ solid mechanics/crystal_plasticity/single_crystal_coupled/model.i regression_tests.global ‑ solid mechanics/crystal_plasticity/single_crystal_decoupled/model.i regression_tests.global ‑ solid mechanics/crystal_plasticity/single_crystal_decoupled_explicit_orientation/model.i ```

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 6 months ago

Test Results (macos-12-Debug-OFF)

3 files ±0 3 suites ±0 2m 48s :stopwatch: +18s 475 tests +2 475 :white_check_mark: +2 0 :zzz: ±0 0 :x: ±0 3 054 runs +2 3 054 :white_check_mark: +2 0 :zzz: ±0 0 :x: ±0

Results for commit 24d0858e. ± Comparison against base commit 2e03afd2.

This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.

``` regression_tests.global ‑ solid mechanics/crystal_plasticity/basic_single_crystal/model.i ``` ``` regression_tests.global ‑ solid mechanics/crystal_plasticity/single_crystal_coupled/model.i regression_tests.global ‑ solid mechanics/crystal_plasticity/single_crystal_decoupled/model.i regression_tests.global ‑ solid mechanics/crystal_plasticity/single_crystal_decoupled_explicit_orientation/model.i ```

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 6 months ago

Test Results (macos-12-Release-OFF)

3 files ±0 3 suites ±0 1m 21s :stopwatch: +43s 475 tests +2 475 :white_check_mark: +2 0 :zzz: ±0 0 :x: ±0 3 052 runs +2 3 052 :white_check_mark: +2 0 :zzz: ±0 0 :x: ±0

Results for commit 24d0858e. ± Comparison against base commit 2e03afd2.

This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.

``` regression_tests.global ‑ solid mechanics/crystal_plasticity/basic_single_crystal/model.i ``` ``` regression_tests.global ‑ solid mechanics/crystal_plasticity/single_crystal_coupled/model.i regression_tests.global ‑ solid mechanics/crystal_plasticity/single_crystal_decoupled/model.i regression_tests.global ‑ solid mechanics/crystal_plasticity/single_crystal_decoupled_explicit_orientation/model.i ```

:recycle: This comment has been updated with latest results.

reverendbedford commented 6 months ago

Coverage after merging sub_implicit_system into main will be

87.22%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
include/neml2/base
CrossRef.h	80.43%	100%	77.78%	100%
DependencyResolver.h	86.13%	100%	88.24%	85.83%	178, 180–181, 185, 188–190, 223, 250, 262, 272–273, 303, 305–306, 308–309
Factory.h	39%	100%	24.69%	100%
NEML2Object.h	50%	100%	22.22%	72.73%	50, 63, 66
OptionCollection.h	0%	100%	0%	0%	40, 49
OptionSet.h	39.75%	100%	36.07%	74.36%	124, 127, 130, 142, 61, 66, 79, 81, 85, 89
Registry.h	81.47%	100%	81.24%	100%
Storage.h	56.10%	100%	39.13%	77.78%	147–148, 150, 177
include/neml2/drivers
Driver.h	0%	100%	0%	0%	56
TransientDriver.h	85.71%	100%	100%	75%	149
include/neml2/misc
error.h	32.53%	100%	30.57%	63.64%	37–38, 40, 94, 96–99
math.h	100%	100%	100%	100%
parser_utils.h	56.07%	100%	46.34%	88%	37–38, 40
utils.h	56.40%	100%	47.30%	77.78%	173, 239, 241–246, 267, 302, 304–307
include/neml2/models
BufferStore.h	34.43%	100%	18.92%	58.33%	113, 115, 117–121, 133, 147, 151
ComposedModel.h	100%	100%	100%	100%
Data.h	100%	100%	100%	100%
Interpolation.h	64.58%	100%	55.56%	91.67%	75
LinearInterpolation.h	20%	100%	8.57%	100%
Model.h	85.19%	100%	75%	89.47%	116, 75
NonlinearParameter.h	10.53%	100%	5.56%	100%
ParameterStore.h	21.43%	100%	5.41%	52.63%	132, 134, 136–140, 148, 152
VariableStore.h	61.07%	100%	52.41%	89.47%	236, 238–239, 260, 91, 97
include/neml2/models/crystallography
CrystalGeometry.h	0%	100%	0%	0%	90, 92
MillerIndex.h	100%	100%	100%	100%
crystallography.h	100%	100%	100%	100%
include/neml2/solvers
Newton.h	100%	100%	100%	100%
NonlinearSystem.h	66.67%	100%	66.67%	66.67%	62
include/neml2/tensors
BatchTensorBase.h	58.59%	100%	43.88%	93.22%	212, 214, 256, 258
FixedDimTensor.h	26.44%	100%	19.32%	65.63%	152, 156, 168, 171, 176, 178, 183, 188, 66, 89, 91
LabeledAxis.h	0%	100%	0%	0%	142, 67, 72, 74–75, 77
LabeledAxisAccessor.h	78.38%	100%	73.91%	85.71%	46, 77
LabeledTensor.h	56.04%	100%	46.88%	77.78%	108, 112, 127, 176, 178–179
Scalar.h	44%	100%	34.55%	70%	82, 84–88
TensorValue.h	14%	100%	10.87%	50%	39, 63, 65, 75
Transformable.h	0%	100%	0%	0%	44
Variable.h	39.58%	100%	30.47%	82%	101, 107, 43–47, 49, 51
VecBase.h	80.95%	100%	50%	100%
src/neml2/base
CrossRef.cxx	83.87%	100%	75%	100%
Factory.cxx	100%	100%	100%	100%
HITParser.cxx	100%	100%	100%	100%
NEML2Object.cxx	90.91%	100%	100%	88.89%	34
OptionCollection.cxx	100%	100%	100%	100%
OptionSet.cxx	83.72%	100%	81.82%	84.38%	118, 120, 130, 132, 35
Registry.cxx	100%	100%	100%	100%
src/neml2/drivers
Driver.cxx	90%	100%	100%	87.50%	35
TransientDriver.cxx	85.06%	100%	100%	83.54%	196–197, 202–204, 207–208, 212–216, 218–223, 226, 231–235, 56, 99
src/neml2/drivers/solid_mechanics
LargeDeformationIncrementalSolidMechanicsDriver.cxx	20.69%	100%	25%	20.37%	100, 102, 104, 108, 110–111, 113–114, 116–117, 120, 122–126, 46, 48–49, 51–52, 54, 56–57, 59, 61–62, 69–70, 72, 74–75, 77–78, 81, 83–85, 87–88, 92, 94, 96
SolidMechanicsDriver.cxx	80%	100%	100%	78.69%	104, 106–107, 110, 112, 114, 117, 119, 133–135, 43, 73
src/neml2/misc
error.cxx	100%	100%	100%	100%
math.cxx	99.44%	100%	100%	99.33%	252
parser_utils.cxx	98.46%	100%	100%	98.18%	73
types.cxx	100%	100%	100%	100%
utils.cxx	89.47%	100%	100%	86.67%	44, 52
src/neml2/models
ArrheniusParameter.cxx	96.55%	100%	100%	96.15%	40
BackwardEulerTimeIntegration.cxx	93.48%	100%	77.78%	97.30%	42
BufferStore.cxx	33.33%	100%	33.33%	33.33%	36, 38, 40, 44, 46, 48–50
ComposedModel.cxx	94.50%	100%	100%	94.06%	100, 102, 146, 39, 52, 58
CopyVariable.cxx	32.86%	100%	33.33%	31.25%	40, 43, 45–46, 48, 52, 54–55, 57–58, 64
Data.cxx	100%	100%	100%	100%
ForceRate.cxx	97.87%	100%	100%	97.56%	41
ForwardEulerTimeIntegration.cxx	97.50%	100%	100%	97.06%	41
ImplicitUpdate.cxx	98.25%	100%	100%	98.11%	39
LinearInterpolation.cxx	61.45%	100%	40.74%	100%
Model.cxx	91.07%	100%	94.44%	90.59%	131–134, 167–169, 276, 278–281, 287, 41, 412, 414–416, 418–419, 69–70, 78, 86
NonlinearParameter.cxx	61.90%	100%	55.56%	100%
ParameterStore.cxx	48.08%	100%	22.73%	66.67%	101, 47, 49, 51–53, 66, 93, 95–96
RotationMatrix.cxx	95%	100%	100%	94.12%	38
SR2Invariant.cxx	96.23%	100%	100%	96%	104, 40
StateRate.cxx	93.62%	100%	66.67%	97.56%	41
SumModel.cxx	82.93%	100%	100%	80%	42, 61–62, 65, 67–69
VariableStore.cxx	94.25%	100%	91.67%	94.67%	165–166, 63, 65
WR2ExplicitExponentialTimeIntegration.cxx	97.06%	100%	100%	96.77%	39
WR2ImplicitExponentialTimeIntegration.cxx	97.22%	100%	100%	96.97%	43
src/neml2/models/crystallography
CrystalGeometry.cxx	98.37%	100%	100%	98.13%	186, 49
CubicCrystal.cxx	92.31%	100%	100%	90.91%	48
MillerIndex.cxx	100%	100%	100%	100%
crystallography.cxx	98.28%	100%	100%	98.08%	142
src/neml2/models/crystallography/user_tensors
FillMillerIndex.cxx	93.33%	100%	100%	91.67%	40
SymmetryFromOrbifold.cxx	90.91%	100%	100%	88.89%	41
src/neml2/models/solid_mechanics
AssociativeIsotropicPlasticHardening.cxx	96.43%	100%	100%	96%	40
AssociativeKinematicPlasticHardening.cxx	96.55%	100%	100%	96.15%	41
AssociativePlasticFlow.cxx	96.15%	100%	100%	95.65%	39
ChabochePlasticHardening.cxx	97.37%	100%	100%	97.14%	43
Eigenstrain.cxx	90%	100%	100%	87.50%	35
ElasticStrain.cxx	96.55%	100%	100%	96.15%	41
Elasticity.cxx	94.44%	100%	100%	93.75%	38
FlowRule.cxx	90%	100%	100%	87.50%	35
GTNYieldFunction.cxx	54.12%	100%	100%	53.29%	139, 159–162, 165, 168–171, 188, 191, 194, 197, 224–228, 231, 234–237, 249, 251, 253–258, 260–264, 266–267, 269–273, 285, 287, 289–290, 292–293, 295–296, 308–311, 313, 315–319, 321–325, 327 © Githubissues. Githubissues is a development platform for aggregating issues.

reverendbedford / neml2