search

reverie-rs / reverie

trace and intercept linux syscalls.
Other
14 stars 5 forks source link

change --tool to --plugin? #26

Closed wangbj closed 5 years ago

wangbj commented 5 years ago

It seems more fit to name it as --plugin instead, what do you think?

rrnewton commented 5 years ago

I was thinking "tool" just because they call them "Pin tools". @chamibuddhika, you've used a lot of these different systems, what are some of the names for the instrumentation tools that run on the instrumentation framework?

Plugin seems to imply that more than one can be plugged in (maybe tool does too? but less so)... we only support one instrumentation tool. In principle, you could support multiple, with setting up trampolines that call more than one function that is "subscribed" to an event. But that is a lot of complexity for something we don't have a use case for ;-).

chamibuddhika commented 5 years ago

AFAIK here is some terminology that I've encountered.

Pin - Tool DynamoRIO - Client Dyninst - Snippet (This is more like at API level so not that relavant I guess)

But that is a lot of complexity for something we don't have a use case for ;-)

Yeah multiple tools would be an advanced use which I feel will bring some (non trivial) complexity. I remember thinking about this kind of thing when I was thinking up an API for liteinst and realizing it could get complicated real fast (at least in liteinst setup where instrumentation can be toggled on and off periodically).

wangbj commented 5 years ago

Got it, will stick with --tool for now.