Update gitignore and add a blurb on top of files generated by build.rs

reverie-rs / reverie

trace and intercept linux syscalls.

Other

14 stars 5 forks source link

Update gitignore and add a blurb on top of files generated by build.rs #50

Closed ckoparkar closed 5 years ago

ckoparkar commented 5 years ago

I'm not so sure about all the build.rs changes. There's a lot of code duplication and adding the corresponding files to .gitignore is sufficient. /cc @rrnewton @wangbj

wangbj commented 5 years ago

Thanks a lot for the PR, is there any reason to use fixed name instead of using mktemp?

ckoparkar commented 5 years ago

Not really. I wanted to avoid adding a dev dependency just for creating a temporary file which we have to rename by hand anyway. I can update this to use the proper crate too.

wangbj commented 5 years ago

build-dependencies is used by build.rs only, it seems better to use mktemp instead of hard code the filename. Others look good.

ckoparkar commented 5 years ago

@wangbj done :) It uses tempfile now.

wangbj commented 5 years ago

Thanks!