search

reverse-hash / bitcoin-full-node-with-docker

A simple way to deploy your own node with Docker! 🐳
MIT License
7 stars 5 forks source link

Beware, default passwords in configuration files #3

Closed cozybear-dev closed 4 months ago

cozybear-dev commented 1 year ago

In the instructions and readme, are no comments regarding the configured credentials. It's advised to let new users change these with their own passwords. I'm receiving my hardware in a few weeks, will update this issue with a PR to easily update this for other new users.

https://github.com/reverse-hash/bitcoin-full-node-with-docker/blob/82bf7d41e05c3ace67bce806ec7c12e37f9dc59c/volumes/bitcoind/bitcoin.conf#L36

https://github.com/reverse-hash/bitcoin-full-node-with-docker/blob/82bf7d41e05c3ace67bce806ec7c12e37f9dc59c/volumes/btc-rpc-explorer/btc-rpc-explorer.env#L37

https://github.com/reverse-hash/bitcoin-full-node-with-docker/blob/82bf7d41e05c3ace67bce806ec7c12e37f9dc59c/volumes/electrs/electrs.conf#L9

reverse-hash commented 1 year ago

Good point! I will be happy to add your suggestions.

EDIT: I took the opportunity to update the documentation with all the notes I was missing knowing that you are going to deploy your node soon.

Please, if something is not clear or do you think that something can be improved, feel free to share it. Your feedback will be very usefull.

reverse-hash commented 4 months ago

Already integrated.