search

reversim / reversim-summit-2020

2 stars 2 forks source link

fixes missing loader for scss in production config #74

Closed jondot closed 4 years ago

jondot commented 4 years ago

After some investigation, looks like this change:

https://github.com/reversim/reversim-summit-2020/commit/041bb212944c0b74bea26fda68801705bc6c9add#diff-756d79f1a0855e43492459219858a1ecL178

Made dev work, but production never worked correctly because it remained the same (loading only bootstrap.scss).

I've aligned scss loading in prod to be the same as dev loading scss.

rantav commented 4 years ago

@jondot thanks for this! Question: Do we really need client/config/webpack.config.dev.js?

jondot commented 4 years ago

@jondot thanks for this! Question: Do we really need client/config/webpack.config.dev.js?

I think so, even if at some point in time they are similar. Other wise we risk dev tooling / config leaking into prod builds in the future