revertinc / revert

Revert makes it incredibly easy to build integrations with any third party API
https://revert.dev
GNU Affero General Public License v3.0
947 stars 74 forks source link

fix: only call `onClose` when passed via props #340

Closed jatinsandilya closed 1 year ago

jatinsandilya commented 1 year ago

Description

As described our users

So we open the hubspot auth page in a new tab with this code -
revertConnect?.open?.("hubspot")
It does open it in a new tab but then we also receive the error in the screenshot,
We were making an api call after the above mentioned line and it was not getting called due to this error.
For now we are making the api call before executing the open function from Revert as a temporary solution.

We are currently using
"@revertdotdev/revert-react": "^0.0.15", 

Type of change

How Has This Been Tested?

Checklist:

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
revert-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2023 7:32am