search

revery-ui / esy-sdl2

Esy-enabled build for SDL2
zlib License
5 stars 9 forks source link

Fix Arch Linux build #16

Closed taylon closed 4 years ago

taylon commented 4 years ago

Hi,

I finally found some time to try and fix #12 which is an issue that breaks the build in ArchLinux.

Many folks using ArchLinux will enjoy using Vim, so I think that having Oni2 building in ArchLinux might be important for the project :)

I didn't have time to try to setup an Arch build in azure pipelines, but I can try that next week

bryphe commented 4 years ago

Hi @taylon , thanks a lot for contributing this fix!

Many folks using ArchLinux will enjoy using Vim, so I think that having Oni2 building in ArchLinux might be important for the project :)

Definitely 😎 Appreciate you diving to this level to get it working! A couple questions inline, but the overall approach looks good and it builds everywhere.

taylon commented 4 years ago

Alright, so I investigated further and noticed that other people were having issues in Arch for other reasons too like https://github.com/onivim/oni2/issues/1778

So I figured that the initial issue was actually because I was running dash in my system by default and that was causing issues when generating the Makefile, so I added CONFIG_SHELL=bash to prevent that issue.

Then the other issue reported is because of gcc 10 (which is the default in Arch) which sets the -fno-common option by default and that makes the build fail as well...

So with both fixes we can build on Arch and Ubuntu just fine :)

bryphe commented 4 years ago

So with both fixes we can build on Arch and Ubuntu just fine :)

Awesome! Thanks for your work on this @taylon - looks great 👍

Appreciate the details too on both the issues hit (the shell issue, and gcc 10).

arthur-mts commented 4 years ago

Thanks for thinking in Arch <3