search

revery-ui / esy-sdl2

Esy-enabled build for SDL2
zlib License
5 stars 9 forks source link

Struct polymorphism: fix member ordering #7

Closed szbergeron closed 4 years ago

szbergeron commented 4 years ago

Fixes an incorrect struct packing optimization that was causing event type to be misread

szbergeron commented 4 years ago

Not really sure why CI is failing on this one, windows log doesn't really have any info

Et7f3 commented 4 years ago

@szbergeron Can you add this snippet https://github.com/microsoft/azure-pipelines-tasks/issues/9421#issuecomment-457374399

szbergeron commented 4 years ago

@Et7f3 add it where? Not sure what file that's talking about

Et7f3 commented 4 years ago

In the CI config file https://github.com/revery-ui/esy-sdl2/blob/master/.ci/esy-build-steps.yml after the npm install -g esy@0.5.8 step so when this step fail again we will have logs to debug.

szbergeron commented 4 years ago

@Et7f3 that would fail for non-windows platforms right? I see reference to C:...

Et7f3 commented 4 years ago

Sorry for this :sweat_smile: I merge and thanks.