bryphe
commented
3 years ago Just wanted to say thanks for the great investigation and detailed notes, as well as the proposed fix @vhanla !
I need to review it / test a bit and see how it integrates with some of the issues like (https://github.com/onivim/oni2/issues/3071 and https://github.com/onivim/oni2/issues/3063) - but really appreciate your help here 👍 Will be very useful when I dive into this!
Link to github repo:
Steps to reproduce: Modify the Examples.re file to start as not decorated (borderless) window. Launch it
esy '@examples' x examplesand maximize (win+up) with aero snapActual Result: The resized (maximized) window is bigger than the current monitor work area rect. e.g. in a screen resolution 1366x768 with a work area rect of 1366x728 is not used to resize, instead the borderless maximized window is resized to 1382x744 which is even bigger than the monitor resolution, as shown in the following screen capture.
As you can see, the maximized window occupies even the space of the other monitor (which is arranged vertically), it is very noticeable if you have the taskbar transparent or disabled on secondary monitor.
Same issue as Oni2's https://github.com/onivim/oni2/issues/1893
Expected Result: Fits the monitor work area rect (the area excluding the taskbar).
Additional Information: I hooked WH_CALLWNDPROCRET for detecting resizing using WM_WINDOWPOSCHANGED windows message and re-resized after the window has been maximized using SetWindowPos by detecting the monitor's work area rect which doesn't work either.
However, if it is resized to 1 pixel less than the work area rect height, it fits almost correctly with the exception that the 1 pixel gap between the window bottom border and the taskbar is present and visible as shown in the following snapshots.
The console (debugging console output) shows that it indeed resized to 1366x727 (exactly 1 pixel less in height). I don't know if this workaround to kind of fix that issue might be suitable for this project, since I really don't know where that resizing overriding is ignoring the work area rect.
Notice that if it is less in height of the work area rect it respects the dimensions to adjust, otherwise, if height is the same or bigger than the work area rect, even this hook is overrided and re-resize is ignored. I don't know why.
These are the changes I did in order to achieve that workaround: https://github.com/vhanla/revery/commit/d19b9d1bd96d4a7c422215dd1f5e1bbd3041ae43
Bare in mind I'm new to ReasonML and it doesn't consider fullscreen mode, which I ignore is supported though.