Closed jericdeleon closed 3 years ago
Since these are only warnings that -Werror
promotes to hard errors, a quick workaround for this is to remove -Werror
from esy-skia's gn/BUILD.gn. The -Wsuggest-destructor-override
option is new in Clang 11 and is auto-enabled due to BUILD.gn using -Weverything
, but I believe these errors are false positives anyway. Not sure about the AVX one though.
Quick solution with a clang++ wrapper:
sudo vim /usr/local/bin/clang++
params=$@
params="${params/-Werror/-Wno-error}"
eval /usr/bin/clang++ "$params"
sudo chmod +x /usr/local/bin/clang++
This should be fixed by #1033. Feel free to reopen if this is incorrect.
Apologies for the vague title. I cannot pinpoint the exact issue on my own. I'll happily update over the course of resolution.
Tried to follow the Building and Installing document on a Pop!_OS 20.10 machine, and failed. Tried to follow the same steps again, this time using a plain vagrant box with ubuntu/groovy64, still had the same issues.
If Ubuntu 20.10 is currently unhandled, can anyone relay the highest Ubuntu version they know that the build instructions work on? (or if any distro is recommended for the relatively smoothest build experience?)
Steps to reproduce:
esy-harfbuzz
, but other than that, nothing of noteOperating System: Ubuntu 20.10
Dependency Versions:
Expected Result:
esy build
will complete successfully.Actual Result:
esy build
fails with the ff: