revery-ui / revery

:zap: Native, high-performance, cross-platform desktop apps - built with Reason!
https://www.outrunlabs.com/revery/
MIT License
8.06k stars 196 forks source link

Ubuntu 20.10: revery-ui/esy-skia build failed #1014

Closed jericdeleon closed 3 years ago

jericdeleon commented 3 years ago

Apologies for the vague title. I cannot pinpoint the exact issue on my own. I'll happily update over the course of resolution.

Tried to follow the Building and Installing document on a Pop!_OS 20.10 machine, and failed. Tried to follow the same steps again, this time using a plain vagrant box with ubuntu/groovy64, still had the same issues.

If Ubuntu 20.10 is currently unhandled, can anyone relay the highest Ubuntu version they know that the build instructions work on? (or if any distro is recommended for the relatively smoothest build experience?)

fknorr commented 3 years ago

Since these are only warnings that -Werror promotes to hard errors, a quick workaround for this is to remove -Werror from esy-skia's gn/BUILD.gn. The -Wsuggest-destructor-override option is new in Clang 11 and is auto-enabled due to BUILD.gn using -Weverything, but I believe these errors are false positives anyway. Not sure about the AVX one though.

pikachunakapika commented 3 years ago

Quick solution with a clang++ wrapper:

sudo vim /usr/local/bin/clang++

params=$@
params="${params/-Werror/-Wno-error}"
eval /usr/bin/clang++ "$params"

sudo chmod +x /usr/local/bin/clang++

zbaylin commented 3 years ago

This should be fixed by #1033. Feel free to reopen if this is incorrect.