fix(notifications): remove startup prompt on macOS

revery-ui / revery

:zap: Native, high-performance, cross-platform desktop apps - built with Reason!

https://www.outrunlabs.com/revery/

MIT License

8.06k stars 196 forks source link

fix(notifications): remove startup prompt on macOS #1020

Closed zbaylin closed 3 years ago

zbaylin commented 3 years ago

This addresses onivim/oni2#2705. Before we were needlessly setting the notification delegate on start, which would prompt the user if they wanted to allow notifications. Now the prompt is shown on first attempt at showing notifications.

bryphe commented 3 years ago

Just tried w/ Onivim - fixes https://github.com/onivim/oni2/issues/2705 :tada: