search

revery-ui / revery

:zap: Native, high-performance, cross-platform desktop apps - built with Reason!
https://www.outrunlabs.com/revery/
MIT License
8.06k stars 196 forks source link

fix(osx): Add release/acquire around dialog, since it may trigger callbacks #1040

Closed bryphe closed 3 years ago

bryphe commented 3 years ago

Issue: A crash in Onivim 2 was discovered - there could be crashes in notification handlers triggered by opening a dialog - https://github.com/onivim/oni2/pull/2967

Defect: The notification handlers expect that the runtime is not acquired when they are called, however, there was a case in runModal that could trigger notification callbacks while the runtime is acquired

Fix: Release / acquire the runtime around runModal