search

revery-ui / revery

:zap: Native, high-performance, cross-platform desktop apps - built with Reason!
https://www.outrunlabs.com/revery/
MIT License
8.06k stars 196 forks source link

chore(build): move project dune-lang from 1.6 -> 2.5 #1045

Closed zbaylin closed 3 years ago

zbaylin commented 3 years ago

Revery has been stuck on dune v1, which, apart from being fairly old at this point, is no longer documented, which makes it hard to find out how to extend our existing dune files. This brings the project's version from 1.6 -> 2.5. Although 2.7 is the latest available, 2.5 is what I brought Oni to in onivim/oni2#2416, and I think for compatibility sake it makes most sense to keep them in sync.

This also brings the nice benefit of having formatted dune files!

zbaylin commented 3 years ago

@bryphe looks like there's a CI failure when fetching packages on Linux: 

E: The repository 'https://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/stable/xUbuntu_18.04  Release' no longer has a Release file.

Any idea how I could fix this?

bryphe commented 3 years ago

Thanks for upgrading us, @zbaylin ! Much better to be on v2.

I just saw that failure as well - I'm not sure if it's an intermittent connection issue, or something actually busted with the sudo apt-get update command / config.

bryphe commented 3 years ago

Ya, weird, seems like it was a transient connection issue - a separate build I kicked off worked: https://dev.azure.com/revery-ui/revery/_build/results?buildId=6972&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb&t=73c4289c-110b-5085-4a98-4009fa5cc9c8

I'll restart that job once the other builds pass (unfortunately I can't restart until the other jobs finish, it seems..)