revery-ui / revery

:zap: Native, high-performance, cross-platform desktop apps - built with Reason!
https://www.outrunlabs.com/revery/
MIT License
8.07k stars 196 forks source link

fix(osx): Fix acquire/release runtime OSX callbacks #1074

Closed bryphe closed 3 years ago

bryphe commented 3 years ago

Issue: In Onivim 2, after removing the acquire/release runtime calls in https://github.com/revery-ui/revery/pull/1072, I saw the native menu was crashing

This actually reproduces in the example app in a couple ways:

Defect: The native menu callbacks assume the runtime will be released, but that's not the case anymore after #1072

Fix: Remove the release/acquire runtime pairs in the callback helper