search

revery-ui / revery

:zap: Native, high-performance, cross-platform desktop apps - built with Reason!
https://www.outrunlabs.com/revery/
MIT License
8.06k stars 196 forks source link

Example: Hacker News Reader #603

Open ghalestrilo opened 4 years ago

ghalestrilo commented 4 years ago

Hi! I noticed some missing examples on your roadmap, and I'm interested in taking on the Hacker News Reader. I searched for issues but none seem related to that. Can I make a fork?

lessp commented 4 years ago

By coincidence I just brought @bryphe's example back to life. Was planning on getting it done by the weekend. Maybe there could be a combined effort! 🤷‍♂

image

ghalestrilo commented 4 years ago

No way, that's too cool! Is seems pretty close to done, though. Let me know if I can actually help with anything in this project! Otherwise, I'll try to find another way to contribute :)

lessp commented 4 years ago

I've continued and pushed the work here: https://github.com/lessp/revery-hacker-news

It's not finished yet, but has the basic functionality. Let me know where you'd like this located @bryphe so I can transfer it!

As said previously, this is just continued work on top of the previous efforts here: https://github.com/revery-ui/revery-fetch/tree/example/initial-hn-app/example

ezgif-4-3f6bf7d93ddc

OhadRau commented 4 years ago

Would be really cool to get this merged into the examples so that we can track regressions & keep it up-to-date with new Revery APIs. Thoughts on putting this in examples/ and hooking it up to one of the tabs?

lessp commented 4 years ago

Would be really cool to get this merged into the examples so that we can track regressions & keep it up-to-date with new Revery APIs. Thoughts on putting this in examples/ and hooking it up to one of the tabs?

Yes, definitely, I've been holding off to move it to the Revery-organisation since it's still moving quite a bit. I've been thinking of using GraphQL instead of basic client-requests, and also add HTTPS-support for Windows which is why I've held off!

lessp commented 4 years ago

Picking this up again, I'm thinking of moving the started example to the Revery organisation, despite previous comments. It'd be helpful to have people contribute as well.

I had hoped to get it done and to use the revery-graphql-hooks-package, but I keep lacking the time for it!

lessp commented 4 years ago

Moved it: https://github.com/revery-ui/revery-hacker-news