revery-ui / revery

:zap: Native, high-performance, cross-platform desktop apps - built with Reason!
https://www.outrunlabs.com/revery/
MIT License
8.06k stars 196 forks source link

shorten reason-native-crash-utils commit hash #897

Closed glennsl closed 4 years ago

glennsl commented 4 years ago

Apparently esy isn't able to unify the full hash and short hash of dependencies, and since it's a pain in the ass to reproduce the full hash in every package that needs it, I opted for just shortening this instead.

Et7f3 commented 4 years ago

We should opt for long hash because with long hash github allow us to fetch directly that commit. With short hash you have to clone master then checkout

glennsl commented 4 years ago

Noted, but IMO having to reproduce the full hash everywhere is a lot more tedious than having to wait a couple extra seconds for a full clone. Unless it's causing other problems, the former is a manual process while the latter is entirely automatic.

Referencing commits directly ought to be a lot rarer than it is though, which would help ease it either way.