search

revery-ui / revery

:zap: Native, high-performance, cross-platform desktop apps - built with Reason!
https://www.outrunlabs.com/revery/
MIT License
8.06k stars 196 forks source link

fix accidentally converting keydown to keyup #899

Closed despairblue closed 4 years ago

despairblue commented 4 years ago

This introduced an accidental change converting KeyDown events into KeyUp events. That lead to Inputs not calling their onKeyDown handler anymore.

https://github.com/revery-ui/revery/commit/e5f363a1ac1d2b3a91f30ce936efa18478fedb1a#diff-dca70cf54f7954dcef8dd3e027ccb53eR21

This fixes it.

Et7f3 commented 4 years ago

Thanks that's work perfectly with #828 I wait CI to be green.