search

revery-ui / revery

:zap: Native, high-performance, cross-platform desktop apps - built with Reason!
https://www.outrunlabs.com/revery/
MIT License
8.06k stars 196 forks source link

feat(window): expose a few more window-options #968

Closed lessp closed 4 years ago

lessp commented 4 years ago

This adds a transparency-option to Window.

EDIT: I guess though, that this puts a transparency on everything, not only the "background-window" as you'd expect. 🤔

Would close #506

github-actions[bot] commented 4 years ago

I have updated your lock dirs and formatted the code. Please @lessp pull the last commit before pushing any more changes.

lessp commented 4 years ago

I'm not sure what to do about the transparency-flag. I think it makes sense to expose it for full opacity, but perhaps we should name it something else as to reserve it for pure background-transparency?

glennsl commented 4 years ago

I'm not sure what to do about the transparency-flag. I think it makes sense to expose it for full opacity, but perhaps we should name it something else as to reserve it for pure background-transparency?

Since it's associated with the window, I don't think it''s a problem. Background transparency would instead be associated with painting I think.

lessp commented 4 years ago

I'm not sure what to do about the transparency-flag. I think it makes sense to expose it for full opacity, but perhaps we should name it something else as to reserve it for pure background-transparency?

Since it's associated with the window, I don't think it''s a problem. Background transparency would instead be associated with painting I think.

Thanks for reviewing and the suggested changes @glennsl!