reviewdog / action-brakeman

Run brakeman with reviewdog 🐶
MIT License
39 stars 25 forks source link

Migrate to composite actions #26

Closed ohbarye closed 2 years ago

ohbarye commented 2 years ago

Issue

closes https://github.com/reviewdog/action-brakeman/issues/15

Change

As like https://github.com/reviewdog/action-rubocop/pull/29, this pull request tries to migrate to composite actions.

I've tested this change with the following YAML on my repo and that works.

name: reviewdog
on: [pull_request]
jobs:
  brakeman:
    name: runner / brakeman
    runs-on: ubuntu-latest
    steps:
      - name: Check out code
        uses: actions/checkout@v1
      - name: Set up Ruby
        uses: ruby/setup-ruby@v1
        with:
          ruby-version: 3.0.3
      - name: brakeman
        uses: ohbarye/action-brakeman@migrate-to-composite-actions
        with:
          brakeman_version: 5.0.2
          github_token: ${{ secrets.github_token }}
          reporter: github-pr-review # Default is github-pr-check

image

mgrachev commented 2 years ago

@ohbarye Hi 👋

Thank you for your contribution! Could you add a test to make sure that everything works? For example: https://github.com/reviewdog/action-rubocop/blob/master/.github/workflows/ci.yml

ohbarye commented 2 years ago

Hi @mgrachev , thx for your review 👏

Thank you for your contribution! Could you add a test to make sure that everything works? For example: https://github.com/reviewdog/action-rubocop/blob/master/.github/workflows/ci.yml

Good suggestion, how about 48f4a9f ?

github-actions[bot] commented 2 years ago

🚀 [bumpr] Bumped! New version:v2.0.0 Changes:v1.7.1...v2.0.0

mgrachev commented 2 years ago

@ohbarye Thanks a lot for your help 🔥