Transfer repo to the reviewdog organization

reviewdog / action-depup

Action which updates dependencies automatically

https://github.com/marketplace/actions/updates-dependencies-automatically

MIT License

19 stars 9 forks source link

Transfer repo to the reviewdog organization #22

Closed rickstaa closed 3 years ago

rickstaa commented 3 years ago

@haya14busa Maybe it is an idea to transfer ownership to the review dog organisation such that multiple members can mantain it. Let me know what you think.

haya14busa commented 3 years ago

I sent @skarzi and @rickstaa as collaborators.

I put this repo under my account because I thought it's general actions and not related to reviewdog, but that's a good point.

Looks like it's ok for existing users to move the owner. https://github.community/t/transferring-github-action-to-another-owner/16581

Let me move the repo to the reviewdog org.

haya14busa commented 3 years ago

TODOs: Change the owner name from haya14busa to reviewdog in ...

[x] README
[x] https://github.com/reviewdog/action-template
[x] All existing action-depup users' repos.

As for the third one, it's a bit tedious to change the all repos. I wish there was a tool that can edit repos under a certain org (or given repos arguments) in bulk. Or we can just change them by hand. Do you have any thought @rickstaa ?

rickstaa commented 3 years ago

I sent @skarzi and @rickstaa as collaborators.

I put this repo under my account because I thought it's general actions and not related to reviewdog, but that's a good point.

Looks like it's ok for existing users to move the owner. https://github.community/t/transferring-github-action-to-another-owner/16581

Let me move the repo to the reviewdog org.

Ah, I see, I was a bit short-sighted on that. In the end, it doesn't matter much under which user/organization the repository is stored. As long as you (and now also me) have the time to merge the pull requests. Under the reviewdog organization, you have more maintainers to help you with that. I leave that choice up to you :).

rickstaa commented 3 years ago

TODOs: Change the owner name from haya14busa to reviewdog in ...
* [x]  README

* [ ]  https://github.com/reviewdog/action-template

* [x]  All existing action-depup users' repos.
As for the third one, it's a bit tedious to change the all repos. I wish there was a tool that can edit repos under a certain org (or given repos arguments) in bulk. Or we can change them by hand. Do you have any thought @rickstaa ?

Actually the third todo isn't an issue. I found out last month that github is smart enough to handle the change using a url redirect :astonished:. To be sure, I performed a new test. You can see the results here. You could however include a old url deprication warning annotation but I think the redirect is already sufficient. This way, new users will use the new url and old can use the old one.

rickstaa commented 3 years ago

I created a pull request to fix todo 2 might you decide to keep the action under the reviewdog organization. We can also open a vote with the rest of the team.

haya14busa commented 3 years ago

Thanks!

One remaining concern is about renovate/dependabot support for updating actions' version with old owner. But, yes, it's true that it's not a big concern as the existing users can use depup as-is. Let's close the issue and see how it will go.

rickstaa commented 3 years ago

@haya14busa I checked the dependabot, and it looks like it is indeed on an old commit. I'm unsure when you transferred the ownership:

I also tried to renovate out but I'm unable to see which tag it is un.

I think these tools might indeed be broken. We can therefore do two things. Revert the repository back to your own personal GitHub. Or add a small depreciation warning for the next couple of releases so that people are aware of the transfer.

Also, please don't feel pressured to host this in the organization. Your personal branch is just as good. I'm happy to assist you with maintaining it there. It was just a suggestion I made based on the fact that you use REVIEWDOG_VERSION in the readme instead of the general VERSION tag. I now see that you can also use this action to update other versions.

haya14busa commented 3 years ago

Looks like the dependabot actually uses the commit of the latest release, so I guess it's no problem?

rickstaa commented 3 years ago

@haya14busa Amazing thanks for re-checking. I think we can close this issue for now. I assume since renovate still finds the dependency it also has no issues. I was however not able to find the commit it is currently focuesd on. Neverteless, If there is any issue with renovating we will likely encounter it in the future when the depup action is switched to v2.