search

reviewdog / action-detect-secrets

GitHub Action: Run detect-secrets with reviewdog
MIT License
22 stars 11 forks source link

File exclusions are ignored #10

Closed robosung closed 3 years ago

robosung commented 3 years ago

In an effort to reduced the scan time (currently at ~5min), we added file exclusions to detect_secrets_flags as illustrated below.

Chore_test_reviewdog_by_robosung_·_Pull_Request__18_·_teamexos_heart-admin

Unfortunately, it appears that the exclusions flags are being ignored.

With exclusions, it should be running around these ranges.

real 0m13.963s user 0m26.986s sys 0m7.150s

levonet commented 3 years ago

Try to remove quotes from arguments. This is similar to the problem in detect-secrets. Additionally, I suggest ignoring the .git folder.

robosung commented 3 years ago

Thanks, that did the trick.

--all-files --force-use-all-plugins --exclude-files src\/vendor --exclude-files src\/nov