search

reviewdog / action-detect-secrets

GitHub Action: Run detect-secrets with reviewdog
MIT License
22 stars 11 forks source link

fix: add safe directory in gitconfig #38

Closed nicolas2mey closed 1 year ago

nicolas2mey commented 1 year ago

Hello

We're facing in all our repositories some issues executing this action

It ends with success state but printing this error 

fatal: detected dubious ownership in repository at '/github/workspace'

The error happens in both public ubuntu and self-hosted runners

image

The behavior of this is that everything is ok on workflows, no secrets are detected and so users can thought no secrets are stored in the repository

Eriwyr commented 1 year ago

We are facing the same issue +1.

review-dog commented 1 year ago

Hi, @nicolas2mey! We merged your PR to reviewdog! 🐶 Thank you for your contribution! ✨

We just invited you to join the @reviewdog organization on GitHub. Accept the invite by visiting https://github.com/orgs/reviewdog/invitation. By joining the team, you'll be a part of reviewdog community and can help the maintenance of reviewdog.

Thanks again!

javierjulio commented 1 year ago

@shogo82148 thank you! Any chance you can please cut a release with this change? We only noticed recently about the silent failed builds but we are not able to resolve using this outside the action. Only works when pulling in this change locked by commit.