search

reviewdog / action-detect-secrets

GitHub Action: Run detect-secrets with reviewdog
MIT License
22 stars 11 forks source link

Add input for setting detect-secrets version #58

Closed javierjulio closed 9 months ago

javierjulio commented 9 months ago

Since detect-secrets can emit several false positives, like the other reviewdog actions, it would help to be able to specify an explicit detect-secrets version as an input. Only option here is to install the latest which can change with a new release. Ideally, we would set a hard coded default version for detect-secrets but that may not be a change we want to implement right now.

Closes #36

github-actions[bot] commented 9 months ago

🏷️ [bumpr] Next version:v0.18.0 Changes:v0.17.0...reviewdog:javierjulio-patch-1

github-actions[bot] commented 9 months ago

🚀 [bumpr] Bumped! New version:v0.18.0 Changes:v0.17.0...v0.18.0

javierjulio commented 9 months ago

@haya14busa sorry, this wasn't intended for release as I was testing this idea out. Sadly, the new input doesn't work here based on the logs. It doesn't seem that there's a way to specify a detect-secrets version that gets picked up in the Dockerfile on building the image. I was trying the runs.env block but noticed it didn't work and figured I'd come back to it the next day. Sorry about that confusion.

I guess for now we can just consider the input as non-functional and consider removing in v1 if ever released, unless we can figure out how to support a version parameter. From reviewing other reviewdog actions, my hunch is this would have to use an actions/setup-python combo with a shell script to install the specified detect-secrets version, like actions-rubocop or actions-brakeman.

haya14busa commented 9 months ago

Ok. Let's revert the change.