search

reviewdog / action-eslint

Run eslint with reviewdog
https://github.com/marketplace?type=actions&query=reviewdog
MIT License
237 stars 64 forks source link

support npm v9 #157

Closed yshrsmz closed 1 year ago

yshrsmz commented 1 year ago

fix: #152

According to the document, npx --offline foo uses locally-cached binary and fails if there's no cached binary.

I'm going to create a PR for action-stylelint once this PR gets merged

yshrsmz commented 1 year ago

@haya14busa @shogo82148 Hi, sorry to bother you, but could you possibly take a look?

yykamei commented 1 year ago

Hi, I need this pull request to be merged 🙏 I came across an error like this, and I guess, this could be solved with the PR.

Screen Shot 2023-02-20 at 9 15 04
davideme commented 1 year ago

Any update on this?

michadvorak-cen38289 commented 1 year ago

ubuntu-latest now has node 18 and npm 9 as a default, please merge and release this fix ASAP

github-actions[bot] commented 1 year ago

🚀 [bumpr] Bumped! New version:v1.18.0 Changes:v1.17.0...v1.18.0

review-dog commented 1 year ago

Hi, @yshrsmz! We merged your PR to reviewdog! 🐶 Thank you for your contribution! ✨

We just invited you to join the @reviewdog organization on GitHub. Accept the invite by visiting https://github.com/orgs/reviewdog/invitation. By joining the team, you'll be a part of reviewdog community and can help the maintenance of reviewdog.

Thanks again!

review-dog commented 1 year ago

Hi, @yshrsmz! We merged your PR to reviewdog! 🐶 Thank you for your contribution! ✨

We just invited you to join the @reviewdog organization on GitHub. Accept the invite by visiting https://github.com/orgs/reviewdog/invitation. By joining the team, you'll be a part of reviewdog community and can help the maintenance of reviewdog.

Thanks again!