search

reviewdog / action-eslint

Run eslint with reviewdog
https://github.com/marketplace?type=actions&query=reviewdog
MIT License
237 stars 63 forks source link

Action runs unversioned script #183

Closed luk-lo closed 9 months ago

luk-lo commented 1 year ago

Hi, I was planning to use this action on our company's GitHub instance but the installation of reviewdog in this action is a bit problematic https://github.com/reviewdog/action-eslint/blob/10ca150f51dbbb963467c37a03c873ba1fa75f91/script.sh#L11 The install.sh script is downloaded from master, i.e. the contents could change anytime even if I pin the version of action-eslint. Could the download be pinned to a specific version so it would not change unless the action-eslint version changes?

javierjulio commented 9 months ago

My understanding is this is by design that the install script is not versioned. Like with other tools this is a way to start the install process with a single, simple command while supporting the case where it can install a specific version of reviewdog. Thank you.