search

reviewdog / action-eslint

Run eslint with reviewdog
https://github.com/marketplace?type=actions&query=reviewdog
MIT License
234 stars 63 forks source link

eslint flat config #193

Closed stephenjason89 closed 8 months ago

stephenjason89 commented 8 months ago

i just switched to the new flat config and my ci fails now.

image

Is eslint flat config supported?

javierjulio commented 8 months ago

@stephenjason89 yes it is. I use it currently on ActiveAdmin. There really isn’t enough info to go off of here though. Let us know if you have anything new to share. Thank you.

stephenjason89 commented 8 months ago

@javierjulio i'm sorry but here are more errors

image image

After switching back to the .eslintrc configuration, the errors disappeared.

Could you assist me in troubleshooting this issue?

here's an example file with the error

image image

Clearly there are no errors with this but it is throwing error

But upon further investigation it kinda have errors on the import type from graphql codegen

image image

do you think it might be related to https://github.com/antfu/nuxt-module-eslint-config ?

Since on ci i am not building the project but eslint is referring to another eslint which is available only upon build

image
javierjulio commented 8 months ago

@stephenjason89 in the second screenshot, the reported error indicates too many warnings are found to be posted. GitHub has hard limits so it's best to keep your PRs as small as possible.

Error: reviewdog: Too many results (annotations) in diff.

Sorry, I don't know what could be wrong. My suggestion would be to start simple. You can run eslint locally, even with the new config format, and see what it reports. From there try to debug and make small changes. Thanks!