search

reviewdog / action-eslint

Run eslint with reviewdog
https://github.com/marketplace?type=actions&query=reviewdog
MIT License
237 stars 63 forks source link

Cannot read property 'url' of undefined [eslint-formatter-rdjson] #57

Closed DanTsk closed 4 years ago

DanTsk commented 4 years ago

For example, ESLint babel/semi rule doesn't have docs property at all. This is rule metadata by ruleId:

{
  messages: [Object: null prototype] {
    missingSemi: 'Missing semicolon.',
    extraSemi: 'Extra semicolon.'
  },
  fixable: 'code'
}

So eslint-formatter-rdjson is failing with TypeError: Cannot read property 'url' of undefined. https://github.com/reviewdog/action-eslint/blob/b502e5047e010ea6140784bbc7398a46ea4515f2/eslint-formatter-rdjson/index.js#L96 Such cases must be handled.

DanTsk commented 4 years ago

@haya14busa can you merge PR and fix this issue, please?