search

reviewdog / action-eslint

Run eslint with reviewdog
https://github.com/marketplace?type=actions&query=reviewdog
MIT License
233 stars 63 forks source link

fail_on_error flag is not working as expected #73

Closed dmchandru closed 3 years ago

dmchandru commented 3 years ago

My workflow config file as follows

jobs:
  eslint:
    name: runner / eslint
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v1
      - name: eslint
        uses: reviewdog/action-eslint@v1
        with:
          reporter: github-pr-review # Change reporter.
          workdir: 'src/'
          fail_on_error: true

Initially the runner was reported the status check as failed if the PR code have any lint issues. But now the status check seems to passed even if the code have lint issues.

plata commented 3 years ago

Can confirm:

You can see that the error got reported but the action still passed. I only noticed it because I'm still using Codacy as well.