reviewdog / action-eslint

Run eslint with reviewdog
https://github.com/marketplace?type=actions&query=reviewdog
MIT License
237 stars 63 forks source link

improve utf8length #84

Closed shogo82148 closed 3 years ago

shogo82148 commented 3 years ago

Current implementation of utf8length is a bit ticky, and it depends the behaviours of unescape. The ECMA-262 standard says that unescape should not be used when writing new ECMAScript code. ref. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/unescape ref. https://262.ecma-international.org/9.0/#sec-additional-ecmascript-features-for-web-browsers