search

reviewdog / action-flake8

Runs flake8 with Reviewdog :dog:
https://github.com/reviewdog/reviewdog
MIT License
17 stars 7 forks source link

fix: fix missing pip bug and add 'python_executable' option #36

Closed rickstaa closed 1 year ago

rickstaa commented 2 years ago

This pull request makes sure that pip will be installed when it is not found. It also adds the python_executable action argument, allowing users to specify the python executable they want to use. It was created to solve #35.

tsuyoshicho commented 2 years ago

ping @rickstaa san

rickstaa commented 2 years ago

@tsuyoshicho Thanks a lot for your feedback!

Is it okay to change the execution environment for subsequent workflows by installing pip? (Assuming that flake8 has no problem).

That's an excellent point. On second thought, I don't think most people would appreciate this. Especially since I'm using the non recommended way of installing pip to support more distributions. Maybe, throw a warning when pip is not found? Alternatively, can we create an install_pip action argument and set the default to false?

If it is a local runner, isn't it the creator's responsibility to create an environment where actions can be executed? (Python symlink, install pip) (Note: Python setup itself in a normal GHA environment is the responsibility of actions/setup-python)

Again I think you are right on this point. Maybe let's throw a warning when python is not found?

Let me know what you think so that I can change this pull request.

tsuyoshicho commented 2 years ago

@rickstaa Thanks response.

I think fix these two point.

tsuyoshicho commented 2 years ago

re-ping @rickstaa san

rickstaa commented 1 year ago

@tsuyoshicho, due to my thesis, sadly haven't had the time to update this PR. You can, of course, also change the pull request yourself to the form you see fit and ask me to review it. Or we can just close it since, as you pointed out in https://github.com/reviewdog/action-flake8/pull/36#pullrequestreview-914991630 the problem encountered in https://github.com/reviewdog/action-flake8/issues/35 is quite an edge use case that will likely not be encountered by a lot of people. 🤔