reviewdog / action-golangci-lint

Run golangci-lint with reviewdog
https://github.com/marketplace?type=actions&query=reviewdog
MIT License
214 stars 41 forks source link

Severity is not being passed from golangci-lint into reviewdog #110

Open algojack opened 3 years ago

algojack commented 3 years ago

When we do --out-format line-number the word error, warning, etc doesn’t appear. So golangci-lint is not telling reviewdog the severity of any issues, and setting default severity: warning in the golangci-lint config doesn’t have any effect.

The work around is to use the “checkstyle” format. Which is an XML format supported by both reviewdog and golangci-lint that includes a severity=“XXX” field.

https://github.com/reviewdog/action-golangci-lint/blob/77873b3ad8215667886946b6f893580883f10d4f/src/main.ts#L63

vinita-razor commented 1 year ago

@algojack What should be the errorformat for "checkstyle" format