search

reviewdog / action-golangci-lint

Run golangci-lint with reviewdog
https://github.com/marketplace?type=actions&query=reviewdog
MIT License
214 stars 41 forks source link

Timeout does not cause failing check #27

Open jszwedko opened 4 years ago

jszwedko commented 4 years ago

We noticed that our check was reporting false negatives because golangci-lint timed out.

I think we could catch that by looking at the exit code: https://github.com/golangci/golangci-lint/blob/master/pkg/exitcodes/exitcodes.go#L8

eddycharly commented 2 years ago

Just noticed the same issue, any plan to fix ?

sebastianbuechler commented 11 months ago

I think that's fixed by https://github.com/reviewdog/action-golangci-lint/pull/622, especially https://github.com/reviewdog/action-golangci-lint/commit/6a7ccedd2882cd33aba4ff8cf947b06c938833c6